[PATCH] D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/wasm/Writer.cpp:1038
   uint32_t TableIndex = TableBase;
   auto HandleRelocs = [&](InputChunk *Chunk) {
     if (!Chunk->Live)
----------------
sbc100 wrote:
> ruiu wrote:
> > This function is getting longer. I wonder if you can move this lambda out of this function.
> Ok to do that in a follow up?
I'd personally like to do beforehand so that the code is cleaner at any point of time, but a follow-up patch is OK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59337/new/

https://reviews.llvm.org/D59337