[PATCH] D59337: [WebAssembly] Error on R_WASM_MEMORY_ADDR relocations against undefined data symbols.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 15 10:49:52 PDT 2019
sbc100 marked an inline comment as done.
sbc100 added inline comments.
================
Comment at: lld/wasm/Writer.cpp:1038
uint32_t TableIndex = TableBase;
auto HandleRelocs = [&](InputChunk *Chunk) {
if (!Chunk->Live)
----------------
ruiu wrote:
> This function is getting longer. I wonder if you can move this lambda out of this function.
Ok to do that in a follow up?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59337/new/
https://reviews.llvm.org/D59337
More information about the llvm-commits
mailing list