[PATCH] D59145: [TSan][libdispatch] Remove dependency on system headers
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 14 13:25:27 PDT 2019
yln marked 2 inline comments as done.
yln added inline comments.
================
Comment at: compiler-rt/lib/tsan/rtl/tsan_dispatch_defs.h:53-56
+// DISPATCH_NOESCAPE is only defined on Apple platforms with at least Xcode 8.
+#ifndef DISPATCH_NOESCAPE
+#define DISPATCH_NOESCAPE
+#endif
----------------
kubamracek wrote:
> Can we just unconditionally define DISPATCH_NOESCAPE now that we don't include the system header?
Will define by copying from:
https://github.com/apple/swift-corelibs-libdispatch/blob/bc00e13bc7e912d4d9028df2a0b2bfa4c0e11323/dispatch/base.h#L200
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59145/new/
https://reviews.llvm.org/D59145
More information about the llvm-commits
mailing list