[PATCH] D59145: [TSan][libdispatch] Remove dependency on system headers

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 14 13:10:26 PDT 2019


kubamracek accepted this revision.
kubamracek added a comment.
This revision is now accepted and ready to land.

Looks good, with a nit (feel free to address it separately).



================
Comment at: compiler-rt/lib/tsan/rtl/tsan_dispatch_defs.h:53-56
+// DISPATCH_NOESCAPE is only defined on Apple platforms with at least Xcode 8.
+#ifndef DISPATCH_NOESCAPE
+#define DISPATCH_NOESCAPE
+#endif
----------------
Can we just unconditionally define DISPATCH_NOESCAPE now that we don't include the system header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59145/new/

https://reviews.llvm.org/D59145





More information about the llvm-commits mailing list