[PATCH] D57598: [VPLAN] Determine Vector Width programmatically.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationPlanner.h:233-234
   /// VF and its cost.
-  VectorizationFactor planInVPlanNativePath(bool OptForSize, unsigned UserVF);
+  VectorizationFactor planInVPlanNativePath(const bool OptForSize,
+                                            const unsigned UserVF);
 
----------------
Meinersbur wrote:
> [nit] It it somewhat unusual to pass by-value with const.
I see, but I run into problems while developing this caused by the fact that I could modify UserVF inside the function. Would a const ref be better? I can try that, if it doesn't work and you don't like this const value, I will revert the interface to the original one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57598/new/

https://reviews.llvm.org/D57598