[PATCH] D57598: [VPLAN] Determine Vector Width programmatically.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorizationPlanner.h:233-234
   /// VF and its cost.
-  VectorizationFactor planInVPlanNativePath(bool OptForSize, unsigned UserVF);
+  VectorizationFactor planInVPlanNativePath(const bool OptForSize,
+                                            const unsigned UserVF);
 
----------------
[nit] It it somewhat unusual to pass by-value with const.


================
Comment at: test/Transforms/LoopVectorize/outer_loop_test1_no_explicit_vect_width.ll:16-17
+;
+; RUN: opt -S -loop-vectorize -enable-vplan-native-path -mtriple aarch64-gnu-linux < %s | FileCheck %s
+; RUN: opt -S -loop-vectorize -enable-vplan-native-path -mtriple x86_64  < %s | FileCheck %s
+; CHECK-LABEL: vector.ph:
----------------
The RUN lines are usually at the top of the file


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57598/new/

https://reviews.llvm.org/D57598