[PATCH] D59293: [llvm-objcopy]Don't implicitly strip sections in segments

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-all-gnu.test:10
+# RUN: llvm-objcopy %t %t4
+# RUN: od %t4 -t x1 -N 4 -j 120 | FileCheck %s --check-prefix=COPY-BYTES
+# RUN: od %t2 -t x1 -N 4 -j 120 | FileCheck %s --check-prefix=STRIP-BYTES
----------------
Does `od` work on windows?


================
Comment at: tools/llvm-objcopy/StripOpts.td:34
 
-def strip_all
-    : Flag<["-", "--"], "strip-all">,
-      HelpText<
-          "Remove non-allocated sections other than .gnu.warning* sections">;
+def strip_all : Flag<[ "-", "--" ], "strip-all">,
+                HelpText<"Remove non-allocated sections outside segments. "
----------------
The spacing around quotes is inconsistent; clang-format past rC356099 should be able to automatically fix this


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59293/new/

https://reviews.llvm.org/D59293