[PATCH] D59293: [llvm-objcopy]Don't implicitly strip sections in segments

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich accepted this revision.
jakehehrlich added a comment.

This isn't precisely what I had in mind but I think its a strict improvement. Tests look good and document the specific behavior well. I think the behavior with zeroing out sections in explicit cases or where we're looking to match GNU behavior precisely is a good idea (and would have been harder to impossible with what I had in mind). The only one I question is --strip-non-alloc but that was something I invented that turned out not to be useful. We could probably remove that and no one would care. There's not standard or use case to guide what should happen there. The guiding principal should probably be "when it doesn't make people scratch their heads, don't remove stuff in segments" which this change adhears to.

LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59293/new/

https://reviews.llvm.org/D59293