[PATCH] D58599: [LLD] Add summary support

[Alexandre Ganea via Phabricator via llvm-commits]

aganea marked an inline comment as done.
aganea added a comment.
aganea added inline comments.


================
Comment at: COFF/PDB.cpp:1365
+void PDBLinker::printStats() {
+  Summary::print(ObjFile::Instances.size(),
+                 "Input OBJ files (expanded from all cmd-line inputs)");
----------------
ruiu wrote:
> I'm sorry to be repeat saying the same thing, but can't you just print them out in this function? This way, there's no chance that some other log message is displayed between the following lines.
Of course, but my original intent was to provide an interface for adding statistics for the whole LLD. Meanning not just for the `PDBLinker`, but allowing to log stats from anywhere. Thus the original intent for buffering the values instead of printing on the spot.
We're drifting away from that, and I can very well remove the `Summary` class, and print everything here. Is that what you suggest?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599