[PATCH] D58599: [LLD] Add summary support

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 14:05:00 PDT 2019


ruiu added inline comments.


================
Comment at: COFF/PDB.cpp:1365
+void PDBLinker::printStats() {
+  Summary::print(ObjFile::Instances.size(),
+                 "Input OBJ files (expanded from all cmd-line inputs)");
----------------
I'm sorry to be repeat saying the same thing, but can't you just print them out in this function? This way, there's no chance that some other log message is displayed between the following lines.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599





More information about the llvm-commits mailing list