[PATCH] D59311: [ELF] Print symbols ordered by profiled guided section layout with verbose.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 13 11:29:08 PDT 2019


pcc added a reviewer: Bigcheese.
pcc added inline comments.


================
Comment at: lld/ELF/CallGraphSort.cpp:235
+      for (int SecIndex : C.Sections)
+        outs() << Sections[SecIndex]->Name << "\n";
+  }
----------------
Should this go to a file with a user-specified name (without the header) instead of stdout? I'd expect the output of this to be consumed by a script, and sending it to a file would probably make it easier for said script to consume.

Also, should this be listing the symbols instead of the sections if the intent is to pass this to --symbol-ordering-file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59311/new/

https://reviews.llvm.org/D59311





More information about the llvm-commits mailing list