[PATCH] D59311: [ELF] Print symbols ordered by profiled guided section layout with verbose.

Wed Mar 13 11:24:27 PDT 2019

tcwang added a comment.

Thank you so much for the comments! Do you care to elaborate more on the test? I am not sure what I should test? Thanks!

================
Comment at: lld/ELF/CallGraphSort.cpp:236
+      for (int SecIndex : C.Sections)
+        outs() << Sections[SecIndex]->Name << "\n";
+    outs() << "**********************************************************\n";
----------------
ruiu wrote:
> Are you sure that all input sections have a name?
Not sure... But if the section doesn't, should I print an empty line, or just skip it?

================
Comment at: lld/test/ELF/cgprofile-print.s:8
+# RUN: echo "D B 10" >> %t.call_graph
+# RUN: ld.lld -e A %t --call-graph-ordering-file %t.call_graph -o %t2 --verbose | FileCheck %s --check-prefix=VERBOSE
+# RUN: llvm-readobj -symbols %t2 | FileCheck %s
----------------
ruiu wrote:
> This does not seem to test the feature that you want to use.  Don't you want to print out the sorting order as a result of parsing .llvm.call-graph-profile sections, do you?
I am sorry that I think I am not sure I understand the comment completely. I was trying to add --verbose to LLD while passing in a call graph file and check the standard print with the expected ordering. (And I have removed the checks in the object file, since this check should be done in another test already.) Should I test something else instead?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59311/new/

https://reviews.llvm.org/D59311