[PATCH] D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer.
Matthew G McGovern via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 12 14:21:25 PDT 2019
mcgov created this revision.
mcgov added reviewers: rnk, mstorsjo, vitalybuka.
Herald added subscribers: Sanitizers, llvm-commits, jdoerfert, dberris, kubamracek.
Herald added projects: LLVM, Sanitizers.
previous test used #pragma data_seg(".CRT.....") to allocate a user defines initializer in the .crt$ segment. A small bug, the correct way to declare this is with init_seg rather than data_seg.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D59273
Files:
test/asan/TestCases/Windows/crt_initializers.cc
Index: test/asan/TestCases/Windows/crt_initializers.cc
===================================================================
--- test/asan/TestCases/Windows/crt_initializers.cc
+++ test/asan/TestCases/Windows/crt_initializers.cc
@@ -26,6 +26,6 @@
void call_me_maybe() {}
-#pragma data_seg(".CRT$XIB")
+#pragma init_seg(".CRT$XIB")
// Add an initializer that shouldn't get its own redzone.
FPTR run_on_startup = call_me_maybe;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59273.190341.patch
Type: text/x-patch
Size: 429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190312/78e3e970/attachment.bin>
More information about the llvm-commits
mailing list