[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld marked 2 inline comments as done.
Hahnfeld added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp:116
     }
+    llvm_unreachable("Previous switch() should have return'ed!");
   case MCSymbolRefExpr::VK_GOT:
----------------
MaskRay wrote:
> ruiu wrote:
> > Ditto -- I'd pass "Invalid relocation type".
> Is this done?
I've updated the message to say "unexpected relocation type!" which is used elsewhere in this file. That should be visible in the latest diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837