[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 04:11:43 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp:116
     }
+    llvm_unreachable("Previous switch() should have return'ed!");
   case MCSymbolRefExpr::VK_GOT:
----------------
ruiu wrote:
> Ditto -- I'd pass "Invalid relocation type".
Is this done?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837





More information about the llvm-commits mailing list