[compiler-rt] r355840 - [HWASan] Fixed minor AArch64/GCC build error.

[Peter Collingbourne via llvm-commits]

I think you could even just omit the .addrsig directive entirely. It
shouldn't make much of a difference here because I wouldn't expect anything
in this file to be ICF'able anyway.

Peter

On Mon, Mar 11, 2019 at 10:05 AM Mitch Phillips via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: hctim
> Date: Mon Mar 11 10:06:39 2019
> New Revision: 355840
>
> URL: http://llvm.org/viewvc/llvm-project?rev=355840&view=rev
> Log:
> [HWASan] Fixed minor AArch64/GCC build error.
>
> Fixed buildbot clang-cmake-aarch64-lld by ensuring clang-only features
> are guarded by clang-only #defines.
>
> Modified:
>     compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S
>
> Modified: compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S?rev=355840&r1=355839&r2=355840&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S (original)
> +++ compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S Mon Mar 11
> 10:06:39 2019
> @@ -100,7 +100,11 @@ __hwasan_tag_mismatch:
>  .Lfunc_end0:
>    .size __hwasan_tag_mismatch, .Lfunc_end0-__hwasan_tag_mismatch
>
> +// Address significance tables cannot be emitted on gcc. Some buildbots
> +// (clang-cmake-aarch64-lld) use gcc to build compiler-rt.
> +#if __clang__
>  .addrsig
> +#endif  // __clang__
>
>  #endif  // defined(__aarch64__)
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190311/b422b7e9/attachment.html>