<div dir="ltr">I think you could even just omit the .addrsig directive entirely. It shouldn't make much of a difference here because I wouldn't expect anything in this file to be ICF'able anyway.<div><br></div><div>Peter</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 11, 2019 at 10:05 AM Mitch Phillips via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: hctim<br>
Date: Mon Mar 11 10:06:39 2019<br>
New Revision: 355840<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=355840&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=355840&view=rev</a><br>
Log:<br>
[HWASan] Fixed minor AArch64/GCC build error.<br>
<br>
Fixed buildbot clang-cmake-aarch64-lld by ensuring clang-only features<br>
are guarded by clang-only #defines.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S<br>
<br>
Modified: compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S?rev=355840&r1=355839&r2=355840&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S?rev=355840&r1=355839&r2=355840&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S (original)<br>
+++ compiler-rt/trunk/lib/hwasan/hwasan_tag_mismatch_aarch64.S Mon Mar 11 10:06:39 2019<br>
@@ -100,7 +100,11 @@ __hwasan_tag_mismatch:<br>
 .Lfunc_end0:<br>
   .size __hwasan_tag_mismatch, .Lfunc_end0-__hwasan_tag_mismatch<br>
<br>
+// Address significance tables cannot be emitted on gcc. Some buildbots<br>
+// (clang-cmake-aarch64-lld) use gcc to build compiler-rt.<br>
+#if __clang__<br>
 .addrsig<br>
+#endif  // __clang__<br>
<br>
 #endif  // defined(__aarch64__)<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>