[PATCH] D58784: [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 08:58:14 PDT 2019


jdenny added a comment.

Has anyone raised a solid objection to this patch?  If not, I see no reason to delay it further.  We can always add replacement assertions later.

This patch does not enable initial `CHECK-{SAME,NEXT,EMPTY}`.  I don't recall a pressing need for a directive that matches only the first line, and we don't seem to be converging on whether it should be one of those or some new directive.  Maybe we should take a step back for a while and try this discussion again later.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58784/new/

https://reviews.llvm.org/D58784





More information about the llvm-commits mailing list