[PATCH] D58784: [FileCheck]Remove assertions that prevent matching an empty string at file start before CHECK-NEXT/SAME
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 11 05:51:50 PDT 2019
probinson added a comment.
In D58784#1424305 <https://reviews.llvm.org/D58784#1424305>, @thopre wrote:
> I think I can be convinced that it is ok to make an initial CHECK-NEXT match the first line of input if an explicit mention to this case is added to the existing documentation for CHECK-NEXT and perhaps also reword the current text slightly to indicate that CHECK-NEXT checks for a match in the next line of input (so that the explicit mention of CHECK-NEXT as first directive feels natural to whoever is reading).
I find CHECK-NEXT as the first directive to be very jarring and un-intuitive.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58784/new/
https://reviews.llvm.org/D58784
More information about the llvm-commits
mailing list