[PATCH] D59170: [lld] [ELF] Print a better error for an archive containing a non-ELF file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 08:43:57 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:1197
+  if (!MB.getBuffer().startswith(ElfMagic))
+    fatal(MB.getBufferIdentifier() + ": expected ELF file in archive");
   if (Endian != ELFDATA2LSB && Endian != ELFDATA2MSB)
----------------
Maybe "not an ELF file" is a better error message as it is more consistent with other error messages below?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59170/new/

https://reviews.llvm.org/D59170





More information about the llvm-commits mailing list