[PATCH] D59170: [lld] [ELF] Print a better error for an archive containing a non-ELF file.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 11 08:42:07 PDT 2019


ruiu added inline comments.


================
Comment at: test/ELF/invalid/invalid-elf.test:4
 
+# RUN: not ld.lld %t %p/Inputs/not-elf.a -o %t2 2>&1 | \
+# RUN:   FileCheck --check-prefix=NOT-ELF %s
----------------
As George pointed out, I think it is better to avoid checking in an .ar file, even though the file does not contain any non-ASCII byte as it is header-only file. You could easily avoid it by creating a new archive file using llvm-ar.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59170/new/

https://reviews.llvm.org/D59170





More information about the llvm-commits mailing list