[PATCH] D59120: [ELF] Sort notes by alignment in decreasing order

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 23:22:12 PST 2019


xiangzhangllvm added a comment.

if just .note.gnu.property require 64-bit alignment, I think it time to change the alignment of this section.

  I think we need change the .note.gnu.property section alignment to 4-byte in Clang-TableGen, because all its element is 4-byte required now. 
  The old ABI required some of note.gnu.property' elements be 8-byte aligned in 64-bit machine, so the section required 8-byte alignment.
  Last year, I found a bug about this alignment between GCC and CLANG, Then I discussed with the ABI designer and changed its element's alignment in https://reviews.llvm.org/D56080 .
  I think there are already no ‘significance’ of 8 byte alignment for this section, we can change it now in LLVM.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59120/new/

https://reviews.llvm.org/D59120





More information about the llvm-commits mailing list