[PATCH] D59120: [ELF] Sort notes by alignment in decreasing order

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 02:10:29 PST 2019


Ah right if two notes had larger alignment and the first was not large
enough to bridge the gap then we'd hit the same issue with my solution.
Peter's solution is in fact the only true solution I think.

Sorting notes does seem like a slight improvement however but the true fix
should come from multiple PT_NOTE segments

On Fri, Mar 8, 2019, 2:02 AM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added a comment.
>
> Peter's suggestion resembles the approach taken by ld.bfd: it can create
> multiple PT_NOTE segments. I also favor this.
>
>
> Repository:
>   rLLD LLVM Linker
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D59120/new/
>
> https://reviews.llvm.org/D59120
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/49314bff/attachment.html>


More information about the llvm-commits mailing list