[PATCH] D59020: [StackMaps] Update llvm-readobj to parse V3 Stackmaps

Jake Hughes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 17:17:53 PST 2019


jacob-hughes added inline comments.


================
Comment at: llvm/test/Object/stackmap-dump.test:1
-RUN: llvm-readobj -stackmap %p/Inputs/stackmap-test.macho-x86-64 | FileCheck %s
+RUN: llvm-readobj -stackmap %p/Inputs/stackmap-test.elf-x86-64 | FileCheck %s
 
----------------
reames wrote:
> Rather than switching from macho to elf, please add an extra run line for ELF.  (i.e. test both)
The reason for this change was that the macho file was created back when v2 stackmaps would have been generated. I recompiled the .ll with with the most recent version of LLVM on my machine (linux) and am not entirely sure how to cross-compile to macho.

If you think it's necessary to have an up to date macho object file too, then I can look into how to make one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59020/new/

https://reviews.llvm.org/D59020





More information about the llvm-commits mailing list