[PATCH] D59160: lit: Remove the binary_feature function and inline it everywhere.

[Mitch Phillips via Phabricator via llvm-commits]

hctim added a comment.

In D59160#1423439 <https://reviews.llvm.org/D59160#1423439>, @zturner wrote:

> I wasn't aware that was even a thing.  If you can confirm that works, then yes defining only the positive featuers would be an improvement.  You might want to announce to the list for visibility though.


Me neither. By my quick grep, it looks like there are 13 places <http://llvm-cs.pcc.me.uk/?q=%5Cs*%28%28%3B%5Cs*%29%7C%28%2F%2F%5Cs*%29%29REQUIRES%3A.*no> where we use a negation-based feature in REQUIRES (i.e. the requirement starts with `no`). I would be happy to do the cleanup next week if this is what we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59160/new/

https://reviews.llvm.org/D59160