[PATCH] D59160: lit: Remove the binary_feature function and inline it everywhere.

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 15:10:42 PST 2019


zturner added a comment.

In D59160#1423435 <https://reviews.llvm.org/D59160#1423435>, @pcc wrote:

> Hmm, I remembered that we can just do e.g. `REQUIRES: !asan`. So maybe we should make that change globally and only define the positive features here.


I wasn't aware that was even a thing.  If you can confirm that works, then yes defining only the positive featuers would be an improvement.  You might want to announce to the list for visibility though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59160/new/

https://reviews.llvm.org/D59160





More information about the llvm-commits mailing list