[PATCH] D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks for the fix. A couple comments below.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:295
     /// True if CFG is modified in any way.
-    bool ModifiedDT;
+    bool DTModified;
 
----------------
I'd either remove this completely, since it isn't used, or migrate to using this instead of passing around a flag parameter.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:7254
     // available to CodeGenPrepare.
-    ModifiedDT = true;
+    DTModified = true;
 
----------------
I think this should still set ModifiedDT so that the caller handles it appropriately (see callsite in optimizeBlock).

The comment doesn't make sense to me...might be stale?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59139/new/

https://reviews.llvm.org/D59139