[PATCH] D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 8 09:49:26 PST 2019


xur created this revision.
xur added reviewers: tejohnson, spatel.
Herald added a subscriber: jdoerfert.

r344412 fixed a huge compile time regression but it needs ModifiedDT flag
to be maintained correctly in optimizations in optimizeBlock() and optimizeInst().

optimizeSelectInst() does not updated the flag ( it updates a different ModifiedDT in CodeGenPrepare class).

This patche propagates the flag in optimizeSelectInst() back to optimizeBlock().

I also change the name of ModifiedDT in CodeGenPrepare class to avoid confusion. It seems ModifiedDT in CodeGenPrepare class is not being used anywhere. We may want to delete it.


https://reviews.llvm.org/D59139

Files:
  lib/CodeGen/CodeGenPrepare.cpp
  test/CodeGen/X86/codegen-prepare-DT.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59139.189874.patch
Type: text/x-patch
Size: 3692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190308/af6c7465/attachment.bin>


More information about the llvm-commits mailing list