[PATCH] D59062: [GlobalISel][AArch64] Always fall back on aarch64.neon.addp.*

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 15:06:11 PST 2019


aemerson added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.h:38
+
+  bool legalizeIntrinsic(MachineInstr &MI, MachineRegisterInfo &MRI,
+                         MachineIRBuilder &MIRBuilder) const;
----------------
paquette wrote:
> arsenm wrote:
> > Should this be added separately by D31359?
> I'm not sure what the status of that patch is, but if it's going to land, sure.
> 
> Otherwise, I guess we get everything through custom legalization anyway, so I'm not sure if it matters.
I don't think we need that patch any more if we can do this with legalizeCustom, it's a subset of this functionality.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59062/new/

https://reviews.llvm.org/D59062





More information about the llvm-commits mailing list