[PATCH] D59062: [GlobalISel][AArch64] Always fall back on aarch64.neon.addp.*

[Jessica Paquette via Phabricator via llvm-commits]

paquette marked 2 inline comments as done.
paquette added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerInfo.cpp:81-84
+  // If the user wants a custom mutation, then we can't really say much about
+  // it. Return true, and trust that they're doing the right thing.
+  if (Rule.getAction() == Custom)
+    return true;
----------------
arsenm wrote:
> Why is this necessary? This should hit the default in the switch. You could alternatively add an explicit case if you want to keep the comment
Because if you hand it a G_INTRINSIC, `Q.Types` ends up with a size of 0 (for some reason), so you crash.


================
Comment at: lib/Target/AArch64/AArch64LegalizerInfo.h:38
+
+  bool legalizeIntrinsic(MachineInstr &MI, MachineRegisterInfo &MRI,
+                         MachineIRBuilder &MIRBuilder) const;
----------------
arsenm wrote:
> Should this be added separately by D31359?
I'm not sure what the status of that patch is, but if it's going to land, sure.

Otherwise, I guess we get everything through custom legalization anyway, so I'm not sure if it matters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59062/new/

https://reviews.llvm.org/D59062