[PATCH] D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2.

[Sunil Srivastava via Phabricator via llvm-commits]

Sunil_Srivastava marked an inline comment as done.
Sunil_Srivastava added inline comments.


================
Comment at: tools/llvm-nm/llvm-nm.cpp:1113
+      if (!SecIOrErr) {
+        consumeError(SecIOrErr.takeError());
+        return '?';
----------------
Sunil_Srivastava wrote:
> jhenderson wrote:
> > Could you add a comment explaining why we throw away the error rather than reporting it here, please?
> I have copied the usage from other places in the same file. I am assuming that consumeError is handling the error.
consumeError() is calling handleAllErrors which handles errors.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59060/new/

https://reviews.llvm.org/D59060