[PATCH] D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2.

[Sunil Srivastava via Phabricator via llvm-commits]

Sunil_Srivastava added inline comments.


================
Comment at: tools/llvm-nm/llvm-nm.cpp:888-889
+      std::string TypeName = I->TypeName;
+      if (TypeName.size() < 18)
+	TypeName = std::string(18-TypeName.size(), ' ') + TypeName;
       outs() << PaddedName << "|" << SymbolAddrStr << "|   " << I->TypeChar
----------------
jhenderson wrote:
> Looks like the indentation got messed up here?
Yes, there is a tab there. Fixing.


================
Comment at: tools/llvm-nm/llvm-nm.cpp:1113
+      if (!SecIOrErr) {
+        consumeError(SecIOrErr.takeError());
+        return '?';
----------------
jhenderson wrote:
> Could you add a comment explaining why we throw away the error rather than reporting it here, please?
I have copied the usage from other places in the same file. I am assuming that consumeError is handling the error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59060/new/

https://reviews.llvm.org/D59060