[PATCH] D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 7 02:47:17 PST 2019
jhenderson added inline comments.
================
Comment at: tools/llvm-nm/llvm-nm.cpp:888-889
+ std::string TypeName = I->TypeName;
+ if (TypeName.size() < 18)
+ TypeName = std::string(18-TypeName.size(), ' ') + TypeName;
outs() << PaddedName << "|" << SymbolAddrStr << "| " << I->TypeChar
----------------
Looks like the indentation got messed up here?
================
Comment at: tools/llvm-nm/llvm-nm.cpp:1113
+ if (!SecIOrErr) {
+ consumeError(SecIOrErr.takeError());
+ return '?';
----------------
Could you add a comment explaining why we throw away the error rather than reporting it here, please?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59060/new/
https://reviews.llvm.org/D59060
More information about the llvm-commits
mailing list