[PATCH] D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2.

[Sunil Srivastava via Phabricator via llvm-commits]

Sunil_Srivastava created this revision.
Sunil_Srivastava added reviewers: mtrent, jhenderson, thegameg, rupprecht, enderby, probinson, wristow.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.

This is a re-submission of https://reviews.llvm.org/D58263 or https://reviews.llvm.org/rL354833, for PR39998 and PR39999.

That checkin was reverted due to an Asan failure. This patch fixes that failure.

In the process of fixing the Asan failure, the overall patch has become much smaller, so I am submitting it as a separate review.

The major simplification vs D58263 <https://reviews.llvm.org/D58263> is that the new virtual function introduced in in that has now been removed. The code in llvm-nm.cpp now relies on Symbol flags already computed earlier.

Other than that there are

1. minor stylistic changes, and
2. a test Object/X86/nm-print-size.s has been enhanced to test "-f sysv" output




Repository:
  rL LLVM

https://reviews.llvm.org/D59060

Files:
  include/llvm/Object/ELFObjectFile.h
  lib/Object/ELFObjectFile.cpp
  test/Object/X86/nm-print-size.s
  test/tools/llvm-nm/X86/sysv-i386.test
  test/tools/llvm-nm/X86/sysv-x86_64.test
  tools/llvm-nm/llvm-nm.cpp
  tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59060.189612.patch
Type: text/x-patch
Size: 8470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190307/f0326a65/attachment.bin>