[PATCH] D59012: [WebAssembly] LTO: Don't include bitcode-only symbols in the symtab
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 6 10:52:23 PST 2019
sbc100 added inline comments.
================
Comment at: lld/wasm/Writer.cpp:953
for (Symbol *Sym : Symtab->getSymbols())
- if (!Sym->isLazy())
+ if (!Sym->isLazy() && Sym->IsUsedInRegularObj)
AddSymbol(Sym);
----------------
pcc wrote:
> Can this just be `if (Sym->IsUsedInRegularObj)`? AFAICT this flag is not set on lazy symbols (nor should it be).
Thanks! Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59012/new/
https://reviews.llvm.org/D59012
More information about the llvm-commits
mailing list