[PATCH] D59012: [WebAssembly] LTO: Don't include bitcode-only symbols in the symtab

[Sam Clegg via Phabricator via llvm-commits]

sbc100 updated this revision to Diff 189538.
sbc100 marked 2 inline comments as done.
sbc100 added a comment.

- feedback


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59012/new/

https://reviews.llvm.org/D59012

Files:
  lld/test/ELF/lto/relocatable.ll
  lld/test/wasm/lto/relocatable.ll
  lld/wasm/Writer.cpp


Index: lld/wasm/Writer.cpp
===================================================================
--- lld/wasm/Writer.cpp
+++ lld/wasm/Writer.cpp
@@ -950,7 +950,7 @@
   };
 
   for (Symbol *Sym : Symtab->getSymbols())
-    if (!Sym->isLazy())
+    if (Sym->IsUsedInRegularObj)
       AddSymbol(Sym);
 
   for (ObjFile *File : Symtab->ObjectFiles) {
Index: lld/test/wasm/lto/relocatable.ll
===================================================================
--- /dev/null
+++ lld/test/wasm/lto/relocatable.ll
@@ -0,0 +1,27 @@
+; RUN: llvm-as %s -o %t1.o
+; RUN: wasm-ld %t1.o -r -o %t
+; RUN: llvm-readobj -symbols %t | FileCheck %s
+
+; CHECK:      Symbols [
+; CHECK-NEXT:   Symbol {
+; CHECK-NEXT:     Name: foo
+; CHECK-NEXT:     Type: FUNCTION (0x0)
+; CHECK-NEXT:     Flags [ (0x0)
+; CHECK-NEXT:     ]
+; CHECK-NEXT:     ElementIndex: 0x0
+; CHECK-NEXT:   }
+; CHECK-NEXT: ]
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+define void @foo() {
+  call void @bar()
+  ret void
+}
+
+define internal void @bar() {
+  ret void
+}
+
+declare i32 @baz(...)
Index: lld/test/ELF/lto/relocatable.ll
===================================================================
--- lld/test/ELF/lto/relocatable.ll
+++ lld/test/ELF/lto/relocatable.ll
@@ -71,3 +71,5 @@
 define internal void @bar() {
   ret void
 }
+
+declare i32 @baz(...)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59012.189538.patch
Type: text/x-patch
Size: 1378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190306/dbe155b0/attachment.bin>