[PATCH] D58959: [DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces"

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 189445.
avl added a comment.

added check for section_end()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58959/new/

https://reviews.llvm.org/D58959

Files:
  llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp


Index: llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
===================================================================
--- llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
+++ llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
@@ -147,9 +147,14 @@
     // Build the function loaded notification message
     iJIT_Method_Load FunctionMessage =
       FunctionDescToIntelJITFormat(*Wrapper, Name->data(), Addr, Size);
-    // TODO: it is neccessary to set proper SectionIndex here.
-    // object::SectionedAddress::UndefSection works for only absolute addresses.
-    DILineInfoTable Lines = Context->getLineInfoForAddressRange({Addr, object::SectionedAddress::UndefSection}, Size);
+
+    uint64_t SectionIndex = object::SectionedAddress::UndefSection;
+    if (auto SectOrErr = Sym.getSection())
+      if (*SectOrErr != Obj.section_end())
+        SectionIndex = SectOrErr.get()->getIndex();
+
+    DILineInfoTable Lines =
+        Context->getLineInfoForAddressRange({Addr, SectionIndex}, Size);
     DILineInfoTable::iterator Begin = Lines.begin();
     DILineInfoTable::iterator End = Lines.end();
     for (DILineInfoTable::iterator It = Begin; It != End; ++It) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58959.189445.patch
Type: text/x-patch
Size: 1224 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190306/4b310a5f/attachment.bin>