[PATCH] D58959: [DebugInfo][ExecutionEngine] follow up for "add SectionedAddress to DebugInfo interfaces"

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 5 21:27:18 PST 2019


avl marked an inline comment as done.
avl added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp:153
+    if (auto SectOrErr = Sym.getSection())
+      SectionIndex = SectOrErr.get()->getIndex();
+
----------------
Hahnfeld wrote:
> According to the documentation, `SymbolRef::getSection` returns a `section_iterator`. Do we need to check against `section_end()`? (`end_sections` in the documentation is wrong!)
Good catch! thanks. though there are many usages of this without checking for section_end(). 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58959/new/

https://reviews.llvm.org/D58959





More information about the llvm-commits mailing list