[PATCH] D58953: [WebAssembly] Disable MachineBlockPlacement pass

[Alon Zakai via Phabricator via llvm-commits]

kripken added a comment.

Code change lgtm, thanks!



================
Comment at: lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:293
 
+  // This pass hurts code size for wasm and sometimes generates irreducible
+  // control flow.
----------------
I would change "and sometimes generates" to "because it can generate", since I believe the issue is just that of irreducibility.

(In theory if we could run that pass with a guarantee it would not create irredicuble control flow then it might be useful for us, although maybe not even then because the wasm VM might  change the block order anyhow...)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58953/new/

https://reviews.llvm.org/D58953