[PATCH] D58953: [WebAssembly] Disable MachineBlockPlacement pass

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 22:47:48 PST 2019


aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/cfg-stackify.ll:2
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -disable-block-placement -verify-machineinstrs -fast-isel=false -machine-sink-split-probability-threshold=0 -cgp-freq-ratio-to-skip-merge=1000 | FileCheck %s
-; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -tail-dup-placement=0 -verify-machineinstrs -fast-isel=false -machine-sink-split-probability-threshold=0 -cgp-freq-ratio-to-skip-merge=1000 | FileCheck -check-prefix=OPT %s
 
----------------
Now that we disabled MachineBlockPlacement, these two commands are equivalent. So deleted all `OPT` tests.


================
Comment at: test/CodeGen/WebAssembly/implicit-def.ll:13
+; CHECK:      i32.const $push[[R:[0-9]+]]=, 0{{$}}
 ; CHECK-NEXT: return $pop[[R]]{{$}}
 define i32 @implicit_def_i32() {
----------------
For this test, the positions of the stackified `IMPLICIT_DEF` changed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58953/new/

https://reviews.llvm.org/D58953





More information about the llvm-commits mailing list