[PATCH] D57737: [AMDGPU] Fix DPP sequence in atomic optimizer.

[Diego Novillo via llvm-commits]

Ah, missed that one.  Thanks!

I'm sync'd to an older snapshot then.

On Tue, Mar 5, 2019 at 8:39 AM David Stuttard via Phabricator <
reviews at reviews.llvm.org> wrote:

> dstuttard added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:256
> -  MDNode *const RegName =
> -      llvm::MDNode::get(Context, llvm::MDString::get(Context, "exec"));
> -  Value *const Metadata = llvm::MetadataAsValue::get(Context, RegName);
> ----------------
> dnovillo wrote:
> > This is leaving the declaration for |Context| unused in line 214.  I'm
> getting build errors with -Wunused-variable.
> There's a later change that removes it. See
> https://llvm.org/svn/llvm-project/llvm/trunk@353704 by Benny Kramer.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57737/new/
>
> https://reviews.llvm.org/D57737
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190305/05afb0b8/attachment.html>