<div dir="ltr">Ah, missed that one.  Thanks!<div><br></div><div>I'm sync'd to an older snapshot then.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 5, 2019 at 8:39 AM David Stuttard via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">dstuttard added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/trunk/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:256<br>
-  MDNode *const RegName =<br>
-      llvm::MDNode::get(Context, llvm::MDString::get(Context, "exec"));<br>
-  Value *const Metadata = llvm::MetadataAsValue::get(Context, RegName);<br>
----------------<br>
dnovillo wrote:<br>
> This is leaving the declaration for |Context| unused in line 214.  I'm getting build errors with -Wunused-variable.<br>
There's a later change that removes it. See  <a href="https://llvm.org/svn/llvm-project/llvm/trunk@353704" rel="noreferrer" target="_blank">https://llvm.org/svn/llvm-project/llvm/trunk@353704</a> by Benny Kramer.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D57737/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57737/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D57737" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57737</a><br>
<br>
<br>
<br>
</blockquote></div>