[PATCH] D54175: [PGO] context sensitive PGO

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 4 15:08:55 PST 2019


Yes. Thanks for the fix!

-Rong

On Mon, Mar 4, 2019 at 3:01 PM Alexey Bataev via Phabricator <
reviews at reviews.llvm.org> wrote:

> ABataev added inline comments.
>
>
> ================
> Comment at:
> llvm/trunk/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:41
> +      : CSInstrName(CSInstrName) {}
> +  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM) {
> +    createProfileFileNameVar(M, CSInstrName);
> ----------------
> rupprecht wrote:
> > ABataev wrote:
> > > Seems to me, it breaks the build with the shared libraries. Could you
> take a look at this?
> > > lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilder.cpp.o: In function
> `llvm::PGOInstrumentationGenCreateVar::run(llvm::Module&,
> llvm::AnalysisManager<llvm::Module>&)':
> > >
> /build/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:42:
> undefined reference to `llvm::createProfileFileNameVar(llvm::Module&,
> llvm::StringRef)'
> > >
> /build/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:43:
> undefined reference to `llvm::createIRLevelProfileFlagVar(llvm::Module&,
> bool)'
> > Not OP, but I also hit this. rL355346 should fix it.
> Thanks for the fix!
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D54175/new/
>
> https://reviews.llvm.org/D54175
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190304/961f196f/attachment.html>


More information about the llvm-commits mailing list