<div dir="ltr"><div>Yes. Thanks for the fix!</div><div><br></div><div>-Rong</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 4, 2019 at 3:01 PM Alexey Bataev via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ABataev added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/trunk/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:41<br>
+      : CSInstrName(CSInstrName) {}<br>
+  PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM) {<br>
+    createProfileFileNameVar(M, CSInstrName);<br>
----------------<br>
rupprecht wrote:<br>
> ABataev wrote:<br>
> > Seems to me, it breaks the build with the shared libraries. Could you take a look at this?<br>
> > lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilder.cpp.o: In function `llvm::PGOInstrumentationGenCreateVar::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&)':<br>
> > /build/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:42: undefined reference to `llvm::createProfileFileNameVar(llvm::Module&, llvm::StringRef)'<br>
> > /build/llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h:43: undefined reference to `llvm::createIRLevelProfileFlagVar(llvm::Module&, bool)'<br>
> Not OP, but I also hit this. rL355346 should fix it.<br>
Thanks for the fix!<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D54175/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54175/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D54175" rel="noreferrer" target="_blank">https://reviews.llvm.org/D54175</a><br>
<br>
<br>
<br>
</blockquote></div></div>