[PATCH] D56587: Introduce DW_OP_LLVM_convert

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1952
+      if (Op.getDescription().Op[I] == Encoding::SizeNA)
+        continue;
+      if (Op.getDescription().Op[I] == Encoding::BaseTypeRef) {
----------------
markus wrote:
> aprantl wrote:
> > Where is this getting copied?
> It is not getting copied at all, 'Encoding::SizeNA` indicates that the operation does not have an operand in this slot. Or maybe I am not understanding the question?
My bad, I was thinking about a non-base-type operand, but it is actually handled in the else branch!


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1952
+      if (Op.getDescription().Op[I] == Encoding::SizeNA)
+        continue;
+      if (Op.getDescription().Op[I] == Encoding::BaseTypeRef) {
----------------
aprantl wrote:
> markus wrote:
> > aprantl wrote:
> > > Where is this getting copied?
> > It is not getting copied at all, 'Encoding::SizeNA` indicates that the operation does not have an operand in this slot. Or maybe I am not understanding the question?
> My bad, I was thinking about a non-base-type operand, but it is actually handled in the else branch!
On second thought, I think we can leave it as is, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56587/new/

https://reviews.llvm.org/D56587