[PATCH] D58557: [NFC][Sanitizer] Hard-code fast/slow unwinder at call site

[Vitaly Buka via llvm-commits]

LGTM

On Wed, Feb 27, 2019 at 3:54 PM Julian Lettner <jlettner at apple.com> wrote:

> Attempted fix:
>
> https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c
>
> I think the problem is that my previous patch made UBSan runtime dependent
> on a symbol from sanitizer_common.
> UBSan is combined with other runtimes which may or may not provide the
> symbol, so I defined it with weak linkage in UBSan.
>
> Please let me know if this is an appropriate fix.
>
> On Feb 27, 2019, at 3:38 PM, Evgenii Stepanov via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> eugenis added a comment.
>
> This bot seems unhappy:
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651
>
>
> Repository:
>  rCRT Compiler Runtime
>
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D58557/new/
>
> https://reviews.llvm.org/D58557
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190228/9a1b168a/attachment.html>