<div dir="ltr">LGTM</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 27, 2019 at 3:54 PM Julian Lettner <<a href="mailto:jlettner@apple.com">jlettner@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">Attempted fix:<div><a href="https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c" target="_blank">https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c</a></div><div><br></div><div>I think the problem is that my previous patch made UBSan runtime dependent on a symbol from sanitizer_common.</div><div>UBSan is combined with other runtimes which may or may not provide the symbol, so I defined it with weak linkage in UBSan.</div><div><br></div><div>Please let me know if this is an appropriate fix.<br><div><br><blockquote type="cite"><div>On Feb 27, 2019, at 3:38 PM, Evgenii Stepanov via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:</div><br class="gmail-m_4152971134712017214Apple-interchange-newline"><div><div>eugenis added a comment.<br><br>This bot seems unhappy:<br><a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/6651</a><br><br><br>Repository:<br>  rCRT Compiler Runtime<br><br>CHANGES SINCE LAST ACTION<br>  <a href="https://reviews.llvm.org/D58557/new/" target="_blank">https://reviews.llvm.org/D58557/new/</a><br><br><a href="https://reviews.llvm.org/D58557" target="_blank">https://reviews.llvm.org/D58557</a><br><br><br><br></div></div></blockquote></div><br></div></div></blockquote></div>