[PATCH] D58763: [llvm-objdump] Should print unknown d_tag in hex format
Xing via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 28 00:10:21 PST 2019
Higuoxing marked an inline comment as done.
Higuoxing added inline comments.
================
Comment at: tools/llvm-objdump/ELFDump.cpp:179
StringRef Str = StringRef(Elf->getDynamicTagAsString(Dyn.d_tag));
----------------
grimar wrote:
> Should getDynamicTagAsString just return `nullptr` on unknown flag maybe?
> (It seems used only once in LLVM, for the place below, btw)
>
> @jhenderson, what do you think?
There are several functions that return "unknown". I am not so confident to change those codes in `/lib`. In my opinion, I think those should return `""`.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58763/new/
https://reviews.llvm.org/D58763
More information about the llvm-commits
mailing list