[PATCH] D58763: [llvm-objdump] Should print unknown d_tag in hex format

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:179
 
     StringRef Str = StringRef(Elf->getDynamicTagAsString(Dyn.d_tag));
 
----------------
Should getDynamicTagAsString just return `nullptr` on unknown flag maybe?
(It seems used only once in LLVM, for the place below, btw)

@jhenderson, what do you think?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58763/new/

https://reviews.llvm.org/D58763