[PATCH] D58689: [scudo][standalone] Add a standalone vector class

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad marked 2 inline comments as done.
cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/vector.h:111
+    return false;
+  return memcmp(Lhs.data(), Rhs.data(), Lhs.size() * sizeof(T)) == 0;
+}
----------------
vitalybuka wrote:
> memcmp here does not look right (as in sanitizer common), as documented it works only for POD
> if you don't need these operators, maybe it's safe just to remove them
I removed both operators & swap that is for sure not used.
Some accessors (begin/end) are currently not used but are low cost so I figure I would leave them.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58689/new/

https://reviews.llvm.org/D58689